This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Add more Http response stream tests #6277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@stephentoub @CIPop PTAL |
Contributor
Author
Contributor
Author
|
Test Innerloop OSX Debug Build and Test please |
Building on PR #6250, added more response stream tests dealing with invalid response body transfer semantics.
| ContentLengthTooLarge, | ||
| ChunkSizeTooLarge, | ||
| MissingChunkTerminator | ||
| } |
Member
There was a problem hiding this comment.
Should this be a flags enum so that multiple failure conditions can be specified, or are they mutually exclusive?
Contributor
Author
There was a problem hiding this comment.
The only two that could be combined as flags would be ChunkSizeTooLarge and MissingChunkTerminator, i.e. both of the invalid conditions could be present. But I currently don't test for that. ContentLengthTooLarge is basically mutually exclusive with the other two chunk related errors. I didn't think it was necessary to test every combination of the chunked failures.
Member
|
A few comments, otherwise LGTM. |
Member
|
LGTM |
stephentoub
added a commit
that referenced
this pull request
Feb 21, 2016
Add more Http response stream tests
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Add more Http response stream tests Commit migrated from dotnet/corefx@363c673
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on PR #6250, added more response stream tests dealing with invalid response body transfer semantics.
I still plan to move the localhost server (recently added to these Http tests) to be Azure based.in the near future.